]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: amd: mvme147: Fix probe banner message
authorDaniel Palmer <daniel@0x0f.com>
Mon, 7 Oct 2024 10:43:17 +0000 (19:43 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Nov 2024 15:22:02 +0000 (16:22 +0100)
[ Upstream commit 82c5b53140faf89c31ea2b3a0985a2f291694169 ]

Currently this driver prints this line with what looks like
a rogue format specifier when the device is probed:
[    2.840000] eth%d: MVME147 at 0xfffe1800, irq 12, Hardware Address xx:xx:xx:xx:xx:xx

Change the printk() for netdev_info() and move it after the
registration has completed so it prints out the name of the
interface properly.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/amd/mvme147.c

index 3f2e4cdd0b83e3d421ba038d50fdae7776903aca..133fe0f1166b0d900c749c38477604477db55ac4 100644 (file)
@@ -106,10 +106,6 @@ struct net_device * __init mvme147lance_probe(int unit)
        address = address >> 8;
        dev->dev_addr[3] = address&0xff;
 
-       printk("%s: MVME147 at 0x%08lx, irq %d, Hardware Address %pM\n",
-              dev->name, dev->base_addr, MVME147_LANCE_IRQ,
-              dev->dev_addr);
-
        lp = netdev_priv(dev);
        lp->ram = __get_dma_pages(GFP_ATOMIC, 3);       /* 32K */
        if (!lp->ram) {
@@ -139,6 +135,9 @@ struct net_device * __init mvme147lance_probe(int unit)
                return ERR_PTR(err);
        }
 
+       netdev_info(dev, "MVME147 at 0x%08lx, irq %d, Hardware Address %pM\n",
+                   dev->base_addr, MVME147_LANCE_IRQ, dev->dev_addr);
+
        return dev;
 }