]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iio: light: opt3001: use macros from bits.h header
authorJoshua Crofts <joshua.crofts1@gmail.com>
Tue, 12 May 2026 10:57:23 +0000 (12:57 +0200)
committerJonathan Cameron <jic23@kernel.org>
Sun, 31 May 2026 09:59:41 +0000 (10:59 +0100)
Use GENMASK() and BIT() macros from bits.h header where it makes
sense. While at it, remove unused macro.

No functional change.

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/opt3001.c

index e6c3665f46be47129097c3997c7551ba9a8f6440..dac3d3818d0a01b4ca53106fa38bb54b8c5373d4 100644 (file)
 #define OPT3001_MANUFACTURER_ID        0x7e
 #define OPT3001_DEVICE_ID      0x7f
 
-#define OPT3001_CONFIGURATION_RN_MASK  (0xf << 12)
+#define OPT3001_CONFIGURATION_RN_MASK  GENMASK(15, 12)
 #define OPT3001_CONFIGURATION_RN_AUTO  (0xc << 12)
 
 #define OPT3001_CONFIGURATION_CT       BIT(11)
 
-#define OPT3001_CONFIGURATION_M_MASK   (3 << 9)
+#define OPT3001_CONFIGURATION_M_MASK   GENMASK(10, 9)
 #define OPT3001_CONFIGURATION_M_SHUTDOWN (0 << 9)
 #define OPT3001_CONFIGURATION_M_SINGLE (1 << 9)
 #define OPT3001_CONFIGURATION_M_CONTINUOUS (2 << 9) /* also 3 << 9 */
 
-#define OPT3001_CONFIGURATION_OVF      BIT(8)
 #define OPT3001_CONFIGURATION_CRF      BIT(7)
 #define OPT3001_CONFIGURATION_FH       BIT(6)
 #define OPT3001_CONFIGURATION_FL       BIT(5)
@@ -51,7 +50,7 @@
 #define OPT3001_CONFIGURATION_POL      BIT(3)
 #define OPT3001_CONFIGURATION_ME       BIT(2)
 
-#define OPT3001_CONFIGURATION_FC_MASK  (3 << 0)
+#define OPT3001_CONFIGURATION_FC_MASK  GENMASK(1, 0)
 
 /* The end-of-conversion enable is located in the low-limit register */
 #define OPT3001_LOW_LIMIT_EOC_ENABLE   0xc000