GH-105684: Require `asyncio.Task` implementations to support `set_name` method (...

diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py
index 32d7e1c481ecc55018e091de6126e9590dcaa72f..f650e6b0488cf8ce0ced1a0fa076758d966dea49 100644 (file)
--- a/Lib/asyncio/base_events.py
+++ b/Lib/asyncio/base_events.py
@@ -443,7 +443,7 @@ class BaseEventLoop(events.AbstractEventLoop):
             else:
                 task = self._task_factory(self, coro, context=context)
 
-            tasks._set_task_name(task, name)
+            task.set_name(name)
 
         return task
 

diff --git a/Lib/asyncio/taskgroups.py b/Lib/asyncio/taskgroups.py
index 06b2e0db86a1fe59010132e5339204da0dbf3d9d..bf92bbaf0d005826f76351b115d53cc051c375d6 100644 (file)
--- a/Lib/asyncio/taskgroups.py
+++ b/Lib/asyncio/taskgroups.py
@@ -163,7 +163,7 @@ class TaskGroup:
             task = self._loop.create_task(coro)
         else:
             task = self._loop.create_task(coro, context=context)
-        tasks._set_task_name(task, name)
+        task.set_name(name)
         # optimization: Immediately call the done callback if the task is
         # already done (e.g. if the coro was able to complete eagerly),
         # and skip scheduling a done callback

diff --git a/Lib/asyncio/tasks.py b/Lib/asyncio/tasks.py
index 4250bb0753879a91137ab90bc855ef68a9547ede..75dd3cb6c2e9874d847a1c650085be3e3030b610 100644 (file)
--- a/Lib/asyncio/tasks.py
+++ b/Lib/asyncio/tasks.py
@@ -68,19 +68,6 @@ def all_tasks(loop=None):
             if futures._get_loop(t) is loop and not t.done()}
 
 
-def _set_task_name(task, name):
-    if name is not None:
-        try:
-            set_name = task.set_name
-        except AttributeError:
-            warnings.warn("Task.set_name() was added in Python 3.8, "
-                      "the method support will be mandatory for third-party "
-                      "task implementations since 3.13.",
-                      DeprecationWarning, stacklevel=3)
-        else:
-            set_name(name)
-
-
 class Task(futures._PyFuture):  # Inherit Python Task implementation
                                 # from a Python Future implementation.
 
@@ -412,7 +399,7 @@ def create_task(coro, *, name=None, context=None):
     else:
         task = loop.create_task(coro, context=context)
 
-    _set_task_name(task, name)
+    task.set_name(name)
     return task
 
 

diff --git a/Lib/test/test_asyncio/test_runners.py b/Lib/test/test_asyncio/test_runners.py
index 811cf8b72488b8ca113320e2b1e9f12e08139c41..b1eb6f492886b35e929c781ec9b26615cef75b03 100644 (file)
--- a/Lib/test/test_asyncio/test_runners.py
+++ b/Lib/test/test_asyncio/test_runners.py
@@ -243,6 +243,8 @@ class RunTests(BaseTest):
             def get_loop(self, *args, **kwargs):
                 return self._task.get_loop(*args, **kwargs)
 
+            def set_name(self, *args, **kwargs):
+                return self._task.set_name(*args, **kwargs)
 
         async def main():
             interrupt_self()

diff --git a/Misc/NEWS.d/next/Library/2023-06-12-10-40-38.gh-issue-105684.yiHkFD.rst b/Misc/NEWS.d/next/Library/2023-06-12-10-40-38.gh-issue-105684.yiHkFD.rst
new file mode 100644 (file)
index 0000000..b0d4eb3
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2023-06-12-10-40-38.gh-issue-105684.yiHkFD.rst
@@ -0,0 +1,3 @@
+Supporting :meth:`asyncio.Task.set_name` is now mandatory for third party task implementations.
+The undocumented :func:`!_set_task_name` function (deprecated since 3.8) has been removed.
+Patch by Kumar Aditya.