]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: iwlwifi: Fix memory leak in iwl_mvm_init()
authorXiu Jianfeng <xiujianfeng@huawei.com>
Wed, 9 Nov 2022 03:52:13 +0000 (11:52 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:22:32 +0000 (16:22 +0200)
[ Upstream commit ed2e916c890944633d6826dce267579334f63ea5 ]

When iwl_opmode_register() fails, it does not unregster rate control,
which will cause a memory leak issue, this patch fixes it.

Fixes: 9f66a397c877 ("iwlwifi: mvm: rs: add ops for the new rate scaling in the FW")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://patch.msgid.link/20221109035213.570-1-xiujianfeng@huawei.com
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/mvm/ops.c

index 9b1a1455a7d517c52f3d7c8f11830ccbe12a61b1..1f14636d6a3a8ebe5cfc5c9dfb7f7866f2c9ce98 100644 (file)
@@ -116,8 +116,10 @@ static int __init iwl_mvm_init(void)
        }
 
        ret = iwl_opmode_register("iwlmvm", &iwl_mvm_ops);
-       if (ret)
+       if (ret) {
                pr_err("Unable to register MVM op_mode: %d\n", ret);
+               iwl_mvm_rate_control_unregister();
+       }
 
        return ret;
 }