]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: Intel: avs: Disable periods-elapsed work when closing PCM
authorCezary Rojewski <cezary.rojewski@intel.com>
Thu, 23 Oct 2025 09:23:47 +0000 (11:23 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 23 Oct 2025 12:42:26 +0000 (13:42 +0100)
avs_dai_fe_shutdown() handles the shutdown procedure for HOST HDAudio
stream while period-elapsed work services its IRQs. As the former
frees the DAI's private context, these two operations shall be
synchronized to avoid slab-use-after-free or worse errors.

Fixes: 0dbb186c3510 ("ASoC: Intel: avs: Update stream status in a separate thread")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20251023092348.3119313-3-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/pcm.c

index 501466bd1f7f69b782e3f7bc9f11a66716809696..80c001120cdd9238e1c3adbdadc41f190a2b6bb2 100644 (file)
@@ -651,6 +651,7 @@ static void avs_dai_fe_shutdown(struct snd_pcm_substream *substream, struct snd_
 
        data = snd_soc_dai_get_dma_data(dai, substream);
 
+       disable_work_sync(&data->period_elapsed_work);
        snd_hdac_ext_stream_release(data->host_stream, HDAC_EXT_STREAM_TYPE_HOST);
        avs_dai_shutdown(substream, dai);
 }