]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] gh-69134: Wait until mapped in SimpleDialog keyboard tests (GH-152690) (GH...
authorSerhiy Storchaka <storchaka@gmail.com>
Sun, 5 Jul 2026 11:37:41 +0000 (14:37 +0300)
committerGitHub <noreply@github.com>
Sun, 5 Jul 2026 11:37:41 +0000 (11:37 +0000)
The SimpleDialog keyboard tests generate key events after focus_force(),
which on Windows are dropped until the toplevel is mapped, so they could
fail intermittently (seen on the Windows10 buildbot as
test_return_no_default).  Wait until the window is mapped in these tests,
as GH-152599 did for the other keyboard tests.

(cherry picked from commit 7d619c2fea131722d0bfdad150c081c44cc0abd7)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Lib/test/test_tkinter/test_simpledialog.py

index 942b7ebf7120b3ac6a274b6e37394357e4ab27c7..64edbb645bc80faf6bcd0869eebaf7c9257690c1 100644 (file)
@@ -49,6 +49,7 @@ class SimpleDialogTest(AbstractTkTest, unittest.TestCase):
     def test_return_activates_default(self):
         # <Return> invokes the default button.
         d = self.create()  # default 0
+        self.require_mapped(d.root)
         d.root.focus_force()
         d.root.update()
         d.root.event_generate('<Return>')
@@ -59,6 +60,7 @@ class SimpleDialogTest(AbstractTkTest, unittest.TestCase):
         # With no default button, <Return> rings the bell and leaves the dialog
         # open instead of activating a button.
         d = self.create(default=None)
+        self.require_mapped(d.root)
         d.root.focus_force()
         d.root.update()
         bells = []