]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915: Use increase_wm_latency() for the 16Gb DIMM w/a
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 19 Sep 2025 19:29:55 +0000 (22:29 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 23 Sep 2025 15:10:57 +0000 (18:10 +0300)
Bump the latency for all watermark levels in the
16Gb+ DIMM w/a. The spec does ask us to do it only for level
0, but it seems more sane to bump all the levels. If the actual
memory access is slower then the wakeup (WM1+) should also
potentially happen earlier.

This also avoids the theoretical case that WM0 would get bumped
higher than WM1+. Not that it is likely to happen because the WM0
latency is always significantly lower than the WM1 latency.

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250919193000.17665-9-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/skl_watermark.c

index 98ca592f6042efef64c90410a30b981c5d20522a..21dd15be74f9868314267e8ca3e3776fb5faec15 100644 (file)
@@ -3256,7 +3256,7 @@ adjust_wm_latency(struct intel_display *display)
         * to avoid any underrun.
         */
        if (need_16gb_dimm_wa(display))
-               wm[0] += 1;
+               increase_wm_latency(display, 1);
 }
 
 static void mtl_read_wm_latency(struct intel_display *display)