ksmbd: Remove redundant 'flush_workqueue()' calls

[ Upstream commit e8d585b2f68c0b10c966ee55146de043429085a3 ]

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- 	flush_workqueue(E);
	destroy_workqueue(E);

Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/ksmbd/ksmbd_work.c b/fs/ksmbd/ksmbd_work.c
index fd58eb4809f6a2bb71544b1702b940af79581d5c..14b9caebf7a4f82fbc9b702a8935b0967393571b 100644 (file)
--- a/fs/ksmbd/ksmbd_work.c
+++ b/fs/ksmbd/ksmbd_work.c
@@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
 
 void ksmbd_workqueue_destroy(void)
 {
-       flush_workqueue(ksmbd_wq);
        destroy_workqueue(ksmbd_wq);
        ksmbd_wq = NULL;
 }

diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
index 9ca29cdb7898fa233d1ad46acd37413482a10d32..86446742f4ad9d91aff4d428317a2a94e2746bd9 100644 (file)
--- a/fs/ksmbd/transport_rdma.c
+++ b/fs/ksmbd/transport_rdma.c
@@ -2049,7 +2049,6 @@ int ksmbd_rdma_destroy(void)
        smb_direct_listener.cm_id = NULL;
 
        if (smb_direct_wq) {
-               flush_workqueue(smb_direct_wq);
                destroy_workqueue(smb_direct_wq);
                smb_direct_wq = NULL;
        }