]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dsdb: Fix CID 1473453: Null pointer dereferences
authorVolker Lendecke <vl@samba.org>
Tue, 2 Mar 2021 10:27:07 +0000 (11:27 +0100)
committerJeremy Allison <jra@samba.org>
Sat, 6 Mar 2021 02:20:05 +0000 (02:20 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/dsdb/samdb/ldb_modules/operational.c

index d66b918e95df580dc6626efb5ee31fe007c7b52e..11b87bdf5ca85b5cfa88e0742063427bde92ebb0 100644 (file)
@@ -446,6 +446,10 @@ static int construct_modifyTimeStamp(struct ldb_module *module,
                const struct dsdb_schema *schema = dsdb_get_schema(ldb, NULL);
                char *value = ldb_timestring(msg, schema->ts_last_change);
 
+               if (value == NULL) {
+                       return ldb_oom(ldb_module_get_ctx(module));
+               }
+
                return ldb_msg_add_string(msg, "modifyTimeStamp", value);
        }
        return ldb_msg_copy_attr(msg, "whenChanged", "modifyTimeStamp");