test-tool: fix leak in delete-gpgsig command

We read the input into a strbuf, so we must free it. Without this, t1016
complains in SANITIZE=leak mode.

The bug was introduced in 7673ecd2dc (t1016-compatObjectFormat: add
tests to verify the conversion between objects, 2023-10-01). But nobody
seems to have noticed, probably because CI did not run these tests until
the fix in 6cd8369ef3 (t/lib-gpg: call prepare_gnupghome() in GPG2
prereq, 2024-07-03).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/helper/test-delete-gpgsig.c b/t/helper/test-delete-gpgsig.c
index e36831af03f6a39414ef9e58804cfba8f11cf299..658c7a37f7decbdbdd33162b8b10099f8afd710b 100644 (file)
--- a/t/helper/test-delete-gpgsig.c
+++ b/t/helper/test-delete-gpgsig.c
@@ -23,8 +23,7 @@ int cmd__delete_gpgsig(int argc, const char **argv)
        if (!strcmp(pattern, "trailer")) {
                size_t payload_size = parse_signed_buffer(buf.buf, buf.len);
                fwrite(buf.buf, 1, payload_size, stdout);
-               fflush(stdout);
-               return 0;
+               goto out;
        }
 
        bufptr = buf.buf;
@@ -56,7 +55,9 @@ int cmd__delete_gpgsig(int argc, const char **argv)
                fwrite(bufptr, 1, (eol - bufptr) + 1, stdout);
                bufptr = eol + 1;
        }
-       fflush(stdout);
 
+out:
+       fflush(stdout);
+       strbuf_release(&buf);
        return 0;
 }