]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
systemctl: fix assert for failed mktime conversion
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 4 Jul 2018 21:54:43 +0000 (23:54 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 4 Jul 2018 21:54:43 +0000 (23:54 +0200)
mktime returns -1 on error, so checking for != 0 is not useful.

src/systemctl/systemctl.c

index d673223a274652e3bbf4008274cf3835e2b82ac4..34b2969f6abf5369475beca87652e3d9d59e2677 100644 (file)
@@ -7823,7 +7823,8 @@ static int parse_shutdown_time_spec(const char *t, usec_t *_u) {
                 tm.tm_min = (int) minute;
                 tm.tm_sec = 0;
 
-                assert_se(s = mktime(&tm));
+                s = mktime(&tm);
+                assert(s >= 0);
 
                 *_u = (usec_t) s * USEC_PER_SEC;