]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
crypto: tegra - Remove the use of dev_err_probe()
authorLiao Yuanhong <liaoyuanhong@vivo.com>
Wed, 20 Aug 2025 12:37:52 +0000 (20:37 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 30 Aug 2025 07:43:26 +0000 (15:43 +0800)
Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/tegra/tegra-se-main.c

index 1c94f1de05467a6aa6167856f395f7de4625dc50..7237f14eaf5ae499a0eec2871c98134a042ced6c 100644 (file)
@@ -310,7 +310,7 @@ static int tegra_se_probe(struct platform_device *pdev)
 
        se->engine = crypto_engine_alloc_init(dev, 0);
        if (!se->engine)
-               return dev_err_probe(dev, -ENOMEM, "failed to init crypto engine\n");
+               return -ENOMEM;
 
        ret = crypto_engine_start(se->engine);
        if (ret) {