]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: Intel: Standardize MCLK error logs across RT boards
authorAravind Anilraj <aravindanilraj0702@gmail.com>
Wed, 1 Apr 2026 22:05:07 +0000 (18:05 -0400)
committerMark Brown <broonie@kernel.org>
Fri, 3 Apr 2026 14:15:02 +0000 (15:15 +0100)
Standardize the error logging in platform_clock_control() by adding
missing newline characters to dev_err() strings. Additionally, include
the return code in the error messages to assist with debugging.

Signed-off-by: Aravind Anilraj <aravindanilraj0702@gmail.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20260401220507.23557-5-aravindanilraj0702@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5640.c
sound/soc/intel/boards/bytcr_rt5651.c
sound/soc/intel/boards/cht_bsw_rt5672.c

index e4c21c9c5b38c7a34bbe162400aab086a5a8d5b8..40da3eea5fa72ebfacde81c437a9fd49d7b464ba 100644 (file)
@@ -285,7 +285,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
        if (SND_SOC_DAPM_EVENT_ON(event)) {
                ret = clk_prepare_enable(priv->mclk);
                if (ret < 0) {
-                       dev_err(card->dev, "could not configure MCLK state\n");
+                       dev_err(card->dev, "could not configure MCLK state: %d\n", ret);
                        return ret;
                }
                ret = byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000);
index 8932fc5d6f4f256a2f4bbebd776cc1cfa5e5f567..62cb4856c7972d07815009c2c29488ec3a0be595 100644 (file)
@@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
        if (SND_SOC_DAPM_EVENT_ON(event)) {
                ret = clk_prepare_enable(priv->mclk);
                if (ret < 0) {
-                       dev_err(card->dev, "could not configure MCLK state");
+                       dev_err(card->dev, "could not configure MCLK state: %d\n", ret);
                        return ret;
                }
                ret = byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50);
index 57d6997eb12fff0579177b5e9148b9c1f34d2c08..fd4cefd298d216852d26334c6c1eea10c860bbb7 100644 (file)
@@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
                        ret = clk_prepare_enable(ctx->mclk);
                        if (ret < 0) {
                                dev_err(card->dev,
-                                       "could not configure MCLK state");
+                                       "could not configure MCLK state: %d\n", ret);
                                return ret;
                        }
                }