]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: qedf: Use designated initializer for struct qed_fcoe_cb_ops
authorKees Cook <kees@kernel.org>
Fri, 2 May 2025 22:41:57 +0000 (15:41 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:04:25 +0000 (11:04 +0100)
commit d8720235d5b5cad86c1f07f65117ef2a96f8bec7 upstream.

Recent fixes to the randstruct GCC plugin allowed it to notice
that this structure is entirely function pointers and is therefore
subject to randomization, but doing so requires that it always use
designated initializers. Explicitly specify the "common" member as being
initialized. Silences:

drivers/scsi/qedf/qedf_main.c:702:9: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
  702 |         {
      |         ^

Fixes: 035f7f87b729 ("randstruct: Enable Clang support")
Link: https://lore.kernel.org/r/20250502224156.work.617-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/qedf/qedf_main.c

index 912845415d9b4207f2cb7cd44e579ce16356475a..22b0bfc3f055d41d99badd437597a631f85be0b9 100644 (file)
@@ -692,7 +692,7 @@ static u32 qedf_get_login_failures(void *cookie)
 }
 
 static struct qed_fcoe_cb_ops qedf_cb_ops = {
-       {
+       .common = {
                .link_update = qedf_link_update,
                .bw_update = qedf_bw_update,
                .schedule_recovery_handler = qedf_schedule_recovery_handler,