hwspinlock: qcom: avoid uninitialized struct members

The reg_field is allocated on stack, so using the REG_FIELD macro will
ensure that unused members do not have uninitialized values.

Fixes: 19a0f61224d2 ("hwspinlock: qcom: Add support for Qualcomm HW Mutex block")
Link: https://sashiko.dev/#/patchset/20260319105947.6237-1-wsa%2Brenesas%40sang-engineering.com
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260512091339.31085-2-wsa+renesas@sang-engineering.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
index 0390979fd765d0fa9b0d2d6c1071f3562edf2b76..712003a4640cc17e71a78b48e62b45bc45bf99e8 100644 (file)
--- a/drivers/hwspinlock/qcom_hwspinlock.c
+++ b/drivers/hwspinlock/qcom_hwspinlock.c
@@ -202,7 +202,6 @@ static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *pdev,
 static int qcom_hwspinlock_probe(struct platform_device *pdev)
 {
        struct hwspinlock_device *bank;
-       struct reg_field field;
        struct regmap *regmap;
        size_t array_size;
        u32 stride;
@@ -224,9 +223,7 @@ static int qcom_hwspinlock_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, bank);
 
        for (i = 0; i < QCOM_MUTEX_NUM_LOCKS; i++) {
-               field.reg = base + i * stride;
-               field.lsb = 0;
-               field.msb = 31;
+               struct reg_field field = REG_FIELD(base + i * stride, 0, 31);
 
                bank->lock[i].priv = devm_regmap_field_alloc(&pdev->dev,
                                                             regmap, field);