]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
tox: Disable W504 ("line break after binary operator")
authorStephen Finucane <stephen@that.guru>
Fri, 26 Oct 2018 09:39:29 +0000 (10:39 +0100)
committerStephen Finucane <stephen@that.guru>
Fri, 26 Oct 2018 09:43:37 +0000 (10:43 +0100)
This was introduced in a recent version of 'pycodestyle'. The
documentation notes [1] that it is mutually exclusive with W503, which
we do enforce, suggesting that we disable one or the other. Avoid the
churn and stick to the older rule, which I personally prefer.

[1] http://pycodestyle.pycqa.org/en/latest/intro.html#error-codes

NOTE(stephenfin): This isn't technically required here, but it does help
us maintain a passing 'pep8' tox target on this branch which is
generally useful for catching things like SyntaxErrors.

Signed-off-by: Stephen Finucane <stephen@that.guru>
(cherry picked from commit 498a8eeaa6c9d1dca8ab29a845325cff1463e815)

tox.ini

diff --git a/tox.ini b/tox.ini
index a64d9587563b820ebbd33028f1905fdf5f48ae2f..327b9e7c14a8db7b8a609aa4e1b77703bf39cec9 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -39,7 +39,12 @@ deps = flake8
 commands = flake8 {posargs} patchwork patchwork/bin/pwclient
 
 [flake8]
-ignore = E129, F405
+# Some rules are ignored as their use makes the code more difficult to read:
+#
+# E129 visually indented line with same indent as next logical line
+# F405 'name' may be undefined, or defined from star imports: 'module'
+# W504 line break after binary operator
+ignore = E129, F405, W504
 exclude = ./patchwork/migrations
 
 [testenv:docs]