]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: ti: k3-am65-main: Fix DSS irq trigger type
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Mon, 6 Nov 2023 09:57:48 +0000 (11:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:20 +0000 (15:35 -0800)
[ Upstream commit b57160859263c083c49482b0d083a586b1517f78 ]

DSS irq trigger type is set to IRQ_TYPE_EDGE_RISING in the DT file, but
the TRM says it is level triggered.

For some reason triggering on rising edge results in double the amount
of expected interrupts, e.g. for normal page flipping test the number of
interrupts per second is 2 * fps. It is as if the IRQ triggers on both
edges. There are no other side effects to this issue than slightly
increased CPU & power consumption due to the extra interrupt.

Switching to IRQ_TYPE_LEVEL_HIGH is correct and fixes the issue, so
let's do that.

Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node")
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
Link: https://lore.kernel.org/r/20231106-am65-dss-clk-edge-v1-1-4a959fec0e1e@ideasonboard.com
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/ti/k3-am65-main.dtsi

index bc460033a37a86cd90256ae71f5285232457b6b9..c98068b6c122a01b9b592d71e203d31cefce0f27 100644 (file)
                assigned-clocks = <&k3_clks 67 2>;
                assigned-clock-parents = <&k3_clks 67 5>;
 
-               interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>;
+               interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>;
 
                dma-coherent;