]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/drm_file: fix use of uninitialized variable
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 3 Nov 2023 13:14:03 +0000 (15:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Feb 2024 20:16:58 +0000 (20:16 +0000)
[ Upstream commit 1d3062fad9c7313fff9970a88e0538a24480ffb8 ]

smatch reports:

drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized symbol 'supported_status'.

'supported_status' is only set in one code path. I'm not familiar with
the code to say if that path will always be ran in real life, but
whether that is the case or not, I think it is good to initialize
'supported_status' to 0 to silence the warning (and possibly fix a bug).

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103-uninit-fixes-v2-1-c22b2444f5f5@ideasonboard.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/drm_file.c

index 446458aca8e99dc60f775bb48cf39ed43fe1dfcd..54a7103c1c0f508c178d77a1f244f25d77bbe0b6 100644 (file)
@@ -958,7 +958,7 @@ void drm_show_memory_stats(struct drm_printer *p, struct drm_file *file)
 {
        struct drm_gem_object *obj;
        struct drm_memory_stats status = {};
-       enum drm_gem_object_status supported_status;
+       enum drm_gem_object_status supported_status = 0;
        int id;
 
        spin_lock(&file->table_lock);