]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: zynq: Check return value of pm_runtime_get_sync
authorSrinivas Neeli <srinivas.neeli@xilinx.com>
Fri, 9 Apr 2021 14:08:05 +0000 (19:38 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:21:12 +0000 (16:21 +0200)
[ Upstream commit a51b2fb94b04ab71e53a71b9fad03fa826941254 ]

Return value of "pm_runtime_get_sync" API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any warning.

Addresses-Coverity: "check_return"
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-zynq.c

index 6b4d10d6e10f6c81bf820e54e7804a0c33e2488b..5038d771ac6e88f44909f3313f6251b964f585b2 100644 (file)
@@ -778,8 +778,11 @@ err_pm_dis:
 static int zynq_gpio_remove(struct platform_device *pdev)
 {
        struct zynq_gpio *gpio = platform_get_drvdata(pdev);
+       int ret;
 
-       pm_runtime_get_sync(&pdev->dev);
+       ret = pm_runtime_get_sync(&pdev->dev);
+       if (ret < 0)
+               dev_warn(&pdev->dev, "pm_runtime_get_sync() Failed\n");
        gpiochip_remove(&gpio->chip);
        clk_disable_unprepare(gpio->clk);
        device_set_wakeup_capable(&pdev->dev, 0);