media: ar0521: Fix return value check in writing initial registers

commit 54bb7671ca6de58929b3994468c330bedb9a3b7e upstream.

The return value from register writes is ignored apart from the last
value. Fix this.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c
index e850c92d847e463a7bc8d56947225c0d158a49cd..5c9c7c52cfc403c9b0392f9e820605db16ed5505 100644 (file)
--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -756,11 +756,12 @@ static int ar0521_power_on(struct device *dev)
                gpiod_set_value(sensor->reset_gpio, 0);
        usleep_range(4500, 5000); /* min 45000 clocks */
 
-       for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++)
+       for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) {
                ret = ar0521_write_regs(sensor, initial_regs[cnt].data,
                                        initial_regs[cnt].count);
                if (ret)
                        goto off;
+       }
 
        ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT,
                               AR0521_REG_SERIAL_FORMAT_MIPI |