]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-132435: Test syntax warnings in a finally block (GH-132436)
authorTomas R. <tomas.roun8@gmail.com>
Sun, 13 Apr 2025 20:44:00 +0000 (22:44 +0200)
committerGitHub <noreply@github.com>
Sun, 13 Apr 2025 20:44:00 +0000 (20:44 +0000)
Lib/test/test_compile.py
Misc/NEWS.d/next/Core_and_Builtins/2025-04-13-10-34-27.gh-issue-131927.otp80n.rst [new file with mode: 0644]

index 0377b3f954f44bda3f5299eb70297a154ba5cdfc..57e5f29b015637f14f6a29bbadc63ad11f97522e 100644 (file)
@@ -1664,6 +1664,26 @@ class TestSpecifics(unittest.TestCase):
 
         self.assertEqual(len(caught), 2)
 
+    def test_compile_warning_in_finally(self):
+        # Ensure that warnings inside finally blocks are
+        # only emitted once despite the block being
+        # compiled twice (for normal execution and for
+        # exception handling).
+        source = textwrap.dedent("""
+            try:
+                pass
+            finally:
+                1 is 1
+        """)
+
+        with warnings.catch_warnings(record=True) as caught:
+            warnings.simplefilter("default")
+            compile(source, '<stdin>', 'exec')
+
+        self.assertEqual(len(caught), 1)
+        self.assertEqual(caught[0].category, SyntaxWarning)
+        self.assertIn("\"is\" with 'int' literal", str(caught[0].message))
+
 class TestBooleanExpression(unittest.TestCase):
     class Value:
         def __init__(self):
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-04-13-10-34-27.gh-issue-131927.otp80n.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-04-13-10-34-27.gh-issue-131927.otp80n.rst
new file mode 100644 (file)
index 0000000..9aa940a
--- /dev/null
@@ -0,0 +1,3 @@
+Compiler warnings originating from the same module and line number are now
+only emitted once, matching the behaviour of warnings emitted from user
+code. This can also be configured with :mod:`warnings` filters.