]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/display: Sanitize PHY_C20_VDR_CUSTOM_SERDES_RATE/DP_RATE field macros
authorImre Deak <imre.deak@intel.com>
Wed, 15 Oct 2025 12:54:40 +0000 (15:54 +0300)
committerMika Kahola <mika.kahola@intel.com>
Thu, 16 Oct 2025 08:46:13 +0000 (11:46 +0300)
Rename the PHY_C20_CUSTOM_SERDES / PHY_C20_CUSTOM_SERDES_MASK register
field names to PHY_C20_DP_RATE / PHY_C20_DP_RATE_MASK, and move the
definitions under the actual register containing the fields.

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Link: https://lore.kernel.org/r/20251015125446.3931198-2-mika.kahola@intel.com
drivers/gpu/drm/i915/display/intel_cx0_phy.c
drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h

index a2d2cecf71217daae0c07d64ef1c91cfe5fc8a45..0d83145eff41f79ef407cbb8b7c2f43cf95fa50f 100644 (file)
@@ -2700,12 +2700,12 @@ static void intel_c20_pll_program(struct intel_display *display,
        /* 5. For DP or 6. For HDMI */
        if (is_dp) {
                intel_cx0_rmw(encoder, owned_lane_mask, PHY_C20_VDR_CUSTOM_SERDES_RATE,
-                             BIT(6) | PHY_C20_CUSTOM_SERDES_MASK,
-                             BIT(6) | PHY_C20_CUSTOM_SERDES(intel_c20_get_dp_rate(port_clock)),
+                             BIT(6) | PHY_C20_DP_RATE_MASK,
+                             BIT(6) | PHY_C20_DP_RATE(intel_c20_get_dp_rate(port_clock)),
                              MB_WRITE_COMMITTED);
        } else {
                intel_cx0_rmw(encoder, owned_lane_mask, PHY_C20_VDR_CUSTOM_SERDES_RATE,
-                             BIT(7) | PHY_C20_CUSTOM_SERDES_MASK,
+                             BIT(7) | PHY_C20_DP_RATE_MASK,
                              is_hdmi_frl(port_clock) ? BIT(7) : 0,
                              MB_WRITE_COMMITTED);
 
index 77eae1d845f7916f30fbfe6f3f4d00691e3e1690..25ab8808e54859cfc6628aacc1f78aed2660e1ec 100644 (file)
 #define PHY_C20_RD_DATA_L              0xC08
 #define PHY_C20_RD_DATA_H              0xC09
 #define PHY_C20_VDR_CUSTOM_SERDES_RATE 0xD00
+#define   PHY_C20_DP_RATE_MASK         REG_GENMASK8(4, 1)
+#define   PHY_C20_DP_RATE(val)         REG_FIELD_PREP8(PHY_C20_DP_RATE_MASK, val)
 #define PHY_C20_VDR_HDMI_RATE          0xD01
 #define   PHY_C20_CONTEXT_TOGGLE       REG_BIT8(0)
-#define   PHY_C20_CUSTOM_SERDES_MASK   REG_GENMASK8(4, 1)
-#define   PHY_C20_CUSTOM_SERDES(val)   REG_FIELD_PREP8(PHY_C20_CUSTOM_SERDES_MASK, val)
 #define PHY_C20_VDR_CUSTOM_WIDTH       0xD02
 #define   PHY_C20_CUSTOM_WIDTH_MASK    REG_GENMASK(1, 0)
 #define   PHY_C20_CUSTOM_WIDTH(val)    REG_FIELD_PREP8(PHY_C20_CUSTOM_WIDTH_MASK, val)