test-string-util: remove several strdupa() calls

This performs the same semantic transformation as the Coccinelle
script 'strdupa.cocci'.
Somehow the existing semantic patch is not properly triggering on
this 'string_replace_char' test.

diff --git a/src/test/test-string-util.c b/src/test/test-string-util.c
index 25ddceb799a5ecd4d8a8091af15af178c0c392e1..d0a2272794c733486ed12c8d0fb83792f58c1ecd 100644 (file)
--- a/src/test/test-string-util.c
+++ b/src/test/test-string-util.c
@@ -1125,11 +1125,11 @@ TEST(strextendf) {
 }
 
 TEST(string_replace_char) {
-        assert_se(streq(string_replace_char(strdupa(""), 'a', 'b'), ""));
-        assert_se(streq(string_replace_char(strdupa("abc"), 'a', 'b'), "bbc"));
-        assert_se(streq(string_replace_char(strdupa("hoge"), 'a', 'b'), "hoge"));
-        assert_se(streq(string_replace_char(strdupa("aaaa"), 'a', 'b'), "bbbb"));
-        assert_se(streq(string_replace_char(strdupa("aaaa"), 'a', '\t'), "\t\t\t\t"));
+        assert_se(streq(string_replace_char(strdupa_safe(""), 'a', 'b'), ""));
+        assert_se(streq(string_replace_char(strdupa_safe("abc"), 'a', 'b'), "bbc"));
+        assert_se(streq(string_replace_char(strdupa_safe("hoge"), 'a', 'b'), "hoge"));
+        assert_se(streq(string_replace_char(strdupa_safe("aaaa"), 'a', 'b'), "bbbb"));
+        assert_se(streq(string_replace_char(strdupa_safe("aaaa"), 'a', '\t'), "\t\t\t\t"));
 }
 
 TEST(strspn_from_end) {