]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: cs35l56: Use header defines for Speaker Volume control definition
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Wed, 3 Jul 2024 09:55:16 +0000 (10:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jul 2024 13:54:06 +0000 (15:54 +0200)
commit c66995ae403073212f5ba60d2079003866c6e130 upstream.

The "Speaker Volume" control was being defined using four hardcoded magic
numbers. There are #defines in the cs35l56.h header for these numbers, so
change the code to use the defined constants.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20240703095517.208077-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/codecs/cs35l56.c

index 758dfdf9d3eac7b7d8b94b672746c4599932fdbd..7f2f2f8c13fae2a0a081949d6c01f0d560e31a4d 100644 (file)
@@ -196,7 +196,11 @@ static const struct snd_kcontrol_new cs35l56_controls[] = {
                       cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw),
        SOC_SINGLE_S_EXT_TLV("Speaker Volume",
                             CS35L56_MAIN_RENDER_USER_VOLUME,
-                            6, -400, 400, 9, 0,
+                            CS35L56_MAIN_RENDER_USER_VOLUME_SHIFT,
+                            CS35L56_MAIN_RENDER_USER_VOLUME_MIN,
+                            CS35L56_MAIN_RENDER_USER_VOLUME_MAX,
+                            CS35L56_MAIN_RENDER_USER_VOLUME_SIGNBIT,
+                            0,
                             cs35l56_dspwait_get_volsw,
                             cs35l56_dspwait_put_volsw,
                             vol_tlv),