generators: fix parameters naming in symlink helper

Coverity gets confused because the names were swapped. The parameters
are all passed in the right position, so there's no functional issue,
but the naming is confusing and trips static analyzers, so fix it.

CID#1621624

Follow-up for 8a9ab3dbbc86cf72ef8f511a3214f66a61f6bd01

diff --git a/src/shared/generator.c b/src/shared/generator.c
index f7ae848d6e195cffe9db980b1f47edf181b73f4a..3df988830d2e038671b01f3b1245f023cfce93e8 100644 (file)
--- a/src/shared/generator.c
+++ b/src/shared/generator.c
@@ -26,11 +26,11 @@
 #include "tmpfile-util.h"
 #include "unit-name.h"
 
-static int symlink_unless_exists(const char *to, const char *from) {
-        (void) mkdir_parents(from, 0755);
+static int symlink_unless_exists(const char *from, const char *to) {
+        (void) mkdir_parents(to, 0755);
 
-        if (symlink(to, from) < 0 && errno != EEXIST)
-                return log_error_errno(errno, "Failed to create symlink %s: %m", from);
+        if (symlink(from, to) < 0 && errno != EEXIST)
+                return log_error_errno(errno, "Failed to create symlink %s: %m", to);
         return 0;
 }