]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completi...
authorSteve Dower <steve.dower@python.org>
Wed, 2 Feb 2022 19:54:27 +0000 (19:54 +0000)
committerGitHub <noreply@github.com>
Wed, 2 Feb 2022 19:54:27 +0000 (19:54 +0000)
Lib/test/test_importlib/test_windows.py
Misc/NEWS.d/next/Tests/2022-02-02-18-14-38.bpo-46616.URvBtE.rst [new file with mode: 0644]

index b3e8e7e6d63fcd2c81714dce2d085428ecf7cfd7..b7dfe865a03a97f9d25ebff7554eec6b540450be 100644 (file)
@@ -60,17 +60,28 @@ def setup_module(machinery, name, path=None):
         root = machinery.WindowsRegistryFinder.REGISTRY_KEY
     key = root.format(fullname=name,
                       sys_version='%d.%d' % sys.version_info[:2])
+    base_key = "Software\\Python\\PythonCore\\{}.{}".format(
+        sys.version_info.major, sys.version_info.minor)
+    assert key.casefold().startswith(base_key.casefold()), (
+        "expected key '{}' to start with '{}'".format(key, base_key))
     try:
         with temp_module(name, "a = 1") as location:
+            try:
+                OpenKey(HKEY_CURRENT_USER, base_key)
+                if machinery.WindowsRegistryFinder.DEBUG_BUILD:
+                    delete_key = os.path.dirname(key)
+                else:
+                    delete_key = key
+            except OSError:
+                delete_key = base_key
             subkey = CreateKey(HKEY_CURRENT_USER, key)
             if path is None:
                 path = location + ".py"
             SetValue(subkey, "", REG_SZ, path)
             yield
     finally:
-        if machinery.WindowsRegistryFinder.DEBUG_BUILD:
-            key = os.path.dirname(key)
-        delete_registry_tree(HKEY_CURRENT_USER, key)
+        if delete_key:
+            delete_registry_tree(HKEY_CURRENT_USER, delete_key)
 
 
 @unittest.skipUnless(sys.platform.startswith('win'), 'requires Windows')
diff --git a/Misc/NEWS.d/next/Tests/2022-02-02-18-14-38.bpo-46616.URvBtE.rst b/Misc/NEWS.d/next/Tests/2022-02-02-18-14-38.bpo-46616.URvBtE.rst
new file mode 100644 (file)
index 0000000..31c63c3
--- /dev/null
@@ -0,0 +1,2 @@
+Ensures ``test_importlib.test_windows`` cleans up registry keys after
+completion.