]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mailbox: exynos: drop superfluous mbox setting per channel
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Fri, 27 Mar 2026 15:12:46 +0000 (16:12 +0100)
committerJassi Brar <jassisinghbrar@gmail.com>
Sun, 29 Mar 2026 15:56:12 +0000 (10:56 -0500)
The core initializes the 'mbox' field exactly like this, so don't
duplicate it in the driver.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Tested-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/exynos-mailbox.c

index 5f2d3b81c1dbec8d1a15353769b4b3a1d6ebdf21..d2355b128ba4338fac9ec0cc527ed7490e768aa1 100644 (file)
@@ -99,7 +99,6 @@ static int exynos_mbox_probe(struct platform_device *pdev)
        struct mbox_controller *mbox;
        struct mbox_chan *chans;
        struct clk *pclk;
-       int i;
 
        exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL);
        if (!exynos_mbox)
@@ -129,9 +128,6 @@ static int exynos_mbox_probe(struct platform_device *pdev)
        mbox->ops = &exynos_mbox_chan_ops;
        mbox->of_xlate = exynos_mbox_of_xlate;
 
-       for (i = 0; i < EXYNOS_MBOX_CHAN_COUNT; i++)
-               chans[i].mbox = mbox;
-
        exynos_mbox->mbox = mbox;
 
        platform_set_drvdata(pdev, exynos_mbox);