]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Backport 42932:
authorNeal Norwitz <nnorwitz@gmail.com>
Tue, 14 Mar 2006 06:47:07 +0000 (06:47 +0000)
committerNeal Norwitz <nnorwitz@gmail.com>
Tue, 14 Mar 2006 06:47:07 +0000 (06:47 +0000)
Try to be a bit more consistent on all platforms:
 python .
 python < .

both print a message, return non-zero and do not core dump.
This hopefully fixes the failure on Solaris.

Lib/test/test_cmd_line.py
Modules/main.c

index 20e4afa6f7840e396ba98d28bb02895fc7f664b3..a4a656d451bd694ecec3ebd57de45f7d6ffde3c2 100644 (file)
@@ -16,14 +16,8 @@ class CmdLineTest(unittest.TestCase):
         return subprocess.call([sys.executable, cmd_line], stderr=subprocess.PIPE)
 
     def test_directories(self):
-         if sys.platform == 'win32':
-             # Exit code for "python .", Error 13: permission denied = 2
-             expected_exit_code = 2
-         else:
-             # Linux has no problem with "python .", Exit code = 0
-             expected_exit_code = 0
-         self.assertEqual(self.exit_code('.'), expected_exit_code)
-         self.assertTrue(self.exit_code('< .') != 0)
+        self.assertNotEqual(self.exit_code('.'), 0)
+        self.assertNotEqual(self.exit_code('< .'), 0)
 
     def verify_valid_flag(self, cmd_line):
         data = self.start_python(cmd_line)
index d511e59763d82d309af2465073b151771faef978..f4f0bf6379326d31ad8e96ed0b00133fa8145e86 100644 (file)
@@ -364,7 +364,8 @@ Py_Main(int argc, char **argv)
                                struct stat sb;
                                if (fstat(fileno(fp), &sb) == 0 &&
                                    S_ISDIR(sb.st_mode)) {
-                                       fprintf(stderr, "%s: warning '%s' is a directory\n", argv[0], filename);
+                                       fprintf(stderr, "%s: '%s' is a directory, cannot continue\n", argv[0], filename);
+                                       return 1;
                                }
                        }
                }