]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
memory: renesas-rpc-if: Simplify printing PTR_ERR with dev_err_probe
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Thu, 26 Feb 2026 20:35:24 +0000 (21:35 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Thu, 5 Mar 2026 11:54:58 +0000 (12:54 +0100)
Use dev_err_probe() to simplify the code and fix Coccinelle warning:

  renesas-rpc-if.c:1010:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260226-memory-simplify-v1-1-ccb94f378628@oss.qualcomm.com
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
drivers/memory/renesas-rpc-if.c

index 58ccc1c02e90616d776336e9491999a10b4a0231..0fb5684561648a6ea079ce44f2544971f7299169 100644 (file)
@@ -1005,11 +1005,9 @@ static int rpcif_probe(struct platform_device *pdev)
                return PTR_ERR(rpc->base);
        rpc->info = of_device_get_match_data(dev);
        rpc->regmap = devm_regmap_init(dev, NULL, rpc, rpc->info->regmap_config);
-       if (IS_ERR(rpc->regmap)) {
-               dev_err(dev, "failed to init regmap for rpcif, error %ld\n",
-                       PTR_ERR(rpc->regmap));
-               return  PTR_ERR(rpc->regmap);
-       }
+       if (IS_ERR(rpc->regmap))
+               return dev_err_probe(dev, PTR_ERR(rpc->regmap),
+                                    "failed to init regmap for rpcif\n");
 
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dirmap");
        rpc->dirmap = devm_ioremap_resource(dev, res);