]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mtd: rawnand: pl353: Use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Sat, 30 Aug 2025 10:06:37 +0000 (18:06 +0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 1 Sep 2025 13:01:09 +0000 (15:01 +0200)
Change the 'ret' variable from u32 to int in pl35x_nand_probe() to store
negative error codes or zero;

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/pl35x-nand-controller.c

index 09440ed4652e73246fb7da9a68e1b452e29d244c..37e92b86bf260d3451ba2a30c249af5e8658706d 100644 (file)
@@ -1137,7 +1137,7 @@ static int pl35x_nand_probe(struct platform_device *pdev)
        struct device *smc_dev = pdev->dev.parent;
        struct amba_device *smc_amba = to_amba_device(smc_dev);
        struct pl35x_nandc *nfc;
-       u32 ret;
+       int ret;
 
        nfc = devm_kzalloc(&pdev->dev, sizeof(*nfc), GFP_KERNEL);
        if (!nfc)