- Fix qname minimisation NXDOMAIN validation lookup failures causing

  error_supers assertion fails.

git-svn-id: file:///svn/unbound/trunk@4780 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/doc/Changelog b/doc/Changelog
index 3710505ce55fe3ecc9acf8b69118ab30ce335641..55cc4c70f014c2758a9bee56bec9ae596fa3e0d9 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,7 @@
+16 July 2018: Wouter
+       - Fix qname minimisation NXDOMAIN validation lookup failures causing
+         error_supers assertion fails.
+
 12 July 2018: Wouter
        - Fix to improve systemd socket activation code file descriptor
          assignment.

diff --git a/iterator/iterator.c b/iterator/iterator.c
index 58a9bff6634c7400dad5890464411075c74c872d..2604856b532202004f0583c418c552a9a0ea109a 100644 (file)
--- a/iterator/iterator.c
+++ b/iterator/iterator.c
@@ -230,11 +230,12 @@ error_supers(struct module_qstate* qstate, int id, struct module_qstate* super)
                                qstate->qinfo.qname, qstate->qinfo.qname_len);
                if(!dpns) {
                        /* not interested */
+                       /* this can happen, for eg. qname minimisation asked
+                        * for an NXDOMAIN to be validated, and used qtype
+                        * A for that, and the error of that, the name, is
+                        * not listed in super_iq->dp */
                        verbose(VERB_ALGO, "subq error, but not interested");
                        log_query_info(VERB_ALGO, "superq", &super->qinfo);
-                       if(super_iq->dp)
-                               delegpt_log(VERB_ALGO, super_iq->dp);
-                       log_assert(0);
                        return;
                } else {
                        /* see if the failure did get (parent-lame) info */