s3:rpc_server: Check function code according to MS-NRPC

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15465
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>

diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
index 61471eadae0f5ec04a8fc60ba83f5749ce46e7a5..c3d0d511f40efd1b4b0ec5068fba99ebf657075f 100644 (file)
--- a/source3/rpc_server/netlogon/srv_netlog_nt.c
+++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
@@ -368,6 +368,12 @@ WERROR _netr_LogonControl2Ex(struct pipes_struct *p,
                r->out.query->info1 = info1;
                break;
        case 2:
+               if (r->in.function_code != NETLOGON_CONTROL_REDISCOVER &&
+                   r->in.function_code != NETLOGON_CONTROL_TC_QUERY &&
+                   r->in.function_code != NETLOGON_CONTROL_TC_VERIFY)
+               {
+                       return WERR_INVALID_PARAMETER;
+               }
                info2 = talloc_zero(p->mem_ctx, struct netr_NETLOGON_INFO_2);
                W_ERROR_HAVE_NO_MEMORY(info2);