]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
auth_set_unix_credentials: Fix calling _dbus_credentials_add_unix_uid without checkin...
authorRalf Habacker <ralf.habacker@freenet.de>
Tue, 5 May 2015 15:08:18 +0000 (17:08 +0200)
committerRalf Habacker <ralf.habacker@freenet.de>
Wed, 6 May 2015 10:14:44 +0000 (12:14 +0200)
Reported by Coverity: CID 54722: Unchecked return value (CHECKED_RETURN)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
dbus/dbus-auth-script.c

index 03be4e20b899ea39f40118c9ae5c25786d287e81..fdbe1fe48b6ead529c1635e93bda0b2e85134b24 100644 (file)
@@ -221,7 +221,10 @@ auth_set_unix_credentials(DBusAuth  *auth,
     _dbus_assert_not_reached ("no memory");
 
   if (uid != DBUS_UID_UNSET)
-    _dbus_credentials_add_unix_uid (credentials, uid);
+    {
+      if (!_dbus_credentials_add_unix_uid (credentials, uid))
+        _dbus_assert_not_reached ("no memory");
+    }
   if (pid != DBUS_PID_UNSET)
     _dbus_credentials_add_pid (credentials, pid);