]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Add missing break statements for Coverity CIDs #406,407.
authorNick Mathewson <nickm@torproject.org>
Tue, 27 Oct 2009 01:35:26 +0000 (21:35 -0400)
committerNick Mathewson <nickm@torproject.org>
Tue, 27 Oct 2009 01:35:26 +0000 (21:35 -0400)
The code for these was super-wrong, but will only break things when we
reset an option on a platform where sizeof(time_t) is different from
sizeof(int).

src/or/config.c

index 4e2a1765dc2b2fedcdcce1d5ed4b17827e8ad801..128aa4da34373a6c4460abd0ce8d650ff5afe693 100644 (file)
@@ -2225,6 +2225,7 @@ option_clear(config_format_t *fmt, or_options_t *options, config_var_t *var)
       break;
     case CONFIG_TYPE_ISOTIME:
       *(time_t*)lvalue = 0;
+      break;
     case CONFIG_TYPE_INTERVAL:
     case CONFIG_TYPE_UINT:
     case CONFIG_TYPE_BOOL:
@@ -2238,6 +2239,7 @@ option_clear(config_format_t *fmt, or_options_t *options, config_var_t *var)
         routerset_free(*(routerset_t**)lvalue);
         *(routerset_t**)lvalue = NULL;
       }
+      break;
     case CONFIG_TYPE_CSV:
       if (*(smartlist_t**)lvalue) {
         SMARTLIST_FOREACH(*(smartlist_t **)lvalue, char *, cp, tor_free(cp));