]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
shared/conf-parser: emit a nicer warning for something like "======"
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 18 Jul 2019 09:30:43 +0000 (11:30 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 18 Jul 2019 09:39:38 +0000 (11:39 +0200)
Urlich Windl wrote on the mailing list:
> I noticed that a line of "=======" in "[Service]" cases the message " Unknown lvalue '' in section 'Service'".

This now becomes:
/etc/systemd/system/eqeqeqeq.service:3: Missing key name before '=', ignoring line.

src/shared/conf-parser.c

index c3af23087031d01d0de9ca66d1c4fbe1144f496f..b4ebc0f44bca1716a785e3a5287cabb833525621 100644 (file)
@@ -249,6 +249,9 @@ static int parse_line(
         if (!e)
                 return log_syntax(unit, LOG_WARNING, filename, line, 0,
                                   "Missing '=', ignoring line.");
+        if (e == l)
+                return log_syntax(unit, LOG_WARNING, filename, line, 0,
+                                  "Missing key name before '=', ignoring line.");
 
         *e = 0;
         e++;