OK, so not freeing these was a mistake. I'll try to be less exuberent next

time :-)

diff --git a/source/smbd/service.c b/source/smbd/service.c
index 524b647b5e210286b88c24eba977c2ea4c1717cb..edac97194e3497f77d9dc531d6d3d0b61a09ce95 100644 (file)
--- a/source/smbd/service.c
+++ b/source/smbd/service.c
@@ -546,6 +546,7 @@ connection_struct *make_connection(char *service,char *user,char *password, int
                                *ecode = ERRaccess;
                                DEBUG(0,( "make_connection: connection to %s denied due to security descriptor.\n",
                                        service ));
+                               conn_free(conn);
                                return NULL;
                        } else {
                                conn->read_only = True;
@@ -556,6 +557,7 @@ connection_struct *make_connection(char *service,char *user,char *password, int
 
        if (!vfs_init(conn)) {
                DEBUG(0, ("vfs_init failed for service %s\n", lp_servicename(SNUM(conn))));
+               conn_free(conn);
                return NULL;
        }