ctdb: Simplify compact_args()

Use talloc_asprintf_addsep()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/ctdb/event/event_tool.c b/ctdb/event/event_tool.c
index 2599458d365e86413509107917a31460abf0780a..1512a8c052b1789ed4def5ed2f14f9bcd4a776ca 100644 (file)
--- a/ctdb/event/event_tool.c
+++ b/ctdb/event/event_tool.c
@@ -56,18 +56,14 @@ static int compact_args(TALLOC_CTX *mem_ctx,
                return 0;
        }
 
-       arg_str = talloc_strdup(mem_ctx, argv[from]);
-       if (arg_str == NULL) {
-               return ENOMEM;
+       arg_str = talloc_strdup(mem_ctx, "");
+       for (i = from; i < argc; i++) {
+               talloc_asprintf_addsep(&arg_str, " ", "%s", argv[i]);
        }
 
-       for (i = from+1; i < argc; i++) {
-               arg_str = talloc_asprintf_append(arg_str, " %s", argv[i]);
-               if (arg_str == NULL) {
-                       return ENOMEM;
-               }
+       if (arg_str == NULL) {
+               return ENOMEM;
        }
-
        *result = arg_str;
        return 0;
 }