]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
busctl: modernize code a bit
authorLennart Poettering <lennart@poettering.net>
Mon, 11 Dec 2017 19:30:07 +0000 (20:30 +0100)
committerLennart Poettering <lennart@poettering.net>
Thu, 14 Dec 2017 09:46:19 +0000 (10:46 +0100)
I am puzzled why coccinelle is unwilling to detect these cases...

src/busctl/busctl.c

index 81140f9d368b9c33e58c6ddfe5cb09719b1ba40f..2e92514c4b5631ecf6a11fe4ebd8fd65fee691c5 100644 (file)
@@ -956,18 +956,14 @@ static int introspect(sd_bus *bus, char **argv) {
                         if (r < 0)
                                 return bus_log_parse_error(r);
 
-                        fclose(mf);
-                        mf = NULL;
+                        mf = safe_fclose(mf);
 
                         z = set_get(members, &((Member) {
                                                 .type = "property",
                                                 .interface = m->interface,
                                                 .name = (char*) name }));
-                        if (z) {
-                                free(z->value);
-                                z->value = buf;
-                                buf = NULL;
-                        }
+                        if (z)
+                                free_and_replace(z->value, buf);
 
                         r = sd_bus_message_exit_container(reply);
                         if (r < 0)