]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: smbd: In mkdir_internal(), use the passed in 'smb_fname_atname' instead of a...
authorJeremy Allison <jra@samba.org>
Mon, 24 May 2021 23:36:43 +0000 (16:36 -0700)
committerRalph Boehme <slow@samba.org>
Wed, 9 Jun 2021 13:14:30 +0000 (13:14 +0000)
atname is a better name, as base_name refers to the name without streams
and this is nothing to do with streams.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/open.c

index a50f99e66309d3a78cd8a510cb2c989331725ee4..6b03eec53c614b0b79dc158386724ddc5693ea2c 100644 (file)
@@ -4401,7 +4401,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
 static NTSTATUS mkdir_internal(connection_struct *conn,
                               struct smb_filename *parent_dir_fname_in, /* parent. */
-                              struct smb_filename *smb_fname_atname_in, /* atname relative to parent. */
+                              struct smb_filename *smb_fname_atname, /* atname relative to parent. */
                               struct smb_filename *smb_dname, /* full pathname from root of share. */
                               uint32_t file_attributes,
                               struct files_struct *fsp)
@@ -4410,7 +4410,6 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
                loadparm_s3_global_substitution();
        mode_t mode;
        struct smb_filename *parent_dir_fname = parent_dir_fname_in;
-       struct smb_filename *base_name = smb_fname_atname_in;
        NTSTATUS status;
        bool posix_open = false;
        bool need_re_stat = false;
@@ -4453,7 +4452,7 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
 
        ret = SMB_VFS_MKDIRAT(conn,
                              parent_dir_fname->fsp,
-                             base_name,
+                             smb_fname_atname,
                              mode);
        if (ret != 0) {
                return map_nt_error_from_unix(errno);