]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib:util: Add FALL_THROUGH statements in charset/charset_macosxfs.c
authorAndreas Schneider <asn@samba.org>
Wed, 26 Jul 2017 16:40:14 +0000 (18:40 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 1 Mar 2018 03:37:41 +0000 (04:37 +0100)
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/util/charset/charset_macosxfs.c

index 895277d001aa41c8f55748433854c8ee4b9eeb79..24e21fd6d2cff7a18aff522c0fc1bcef97d4cb9c 100644 (file)
@@ -457,10 +457,11 @@ static size_t macosxfs_encoding_pull(
 
        switch(result) {
        case kCFStringEncodingConversionSuccess:
-               if (*inbytesleft == srcCharsUsed)
+               if (*inbytesleft == srcCharsUsed) {
                        break;
-               else
-                       ; /*fall through*/
+               }
+
+               FALL_THROUGH;
        case kCFStringEncodingInsufficientOutputBufferLength:
                debug_out("String conversion: "
                          "Output buffer too small\n");
@@ -546,10 +547,11 @@ static size_t macosxfs_encoding_push(
 
        switch(result) {
        case kCFStringEncodingConversionSuccess:
-               if (*inbytesleft/2 == srcCharsUsed)
+               if (*inbytesleft/2 == srcCharsUsed) {
                        break;
-               else
-                       ; /*fall through*/
+               }
+
+               FALL_THROUGH;
        case kCFStringEncodingInsufficientOutputBufferLength:
                debug_out("String conversion: "
                          "Output buffer too small\n");