]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: i2c: imx296: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:04 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:21 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx296.c

index f3bec16b527c445d6e82e7dcef6f63ffe3b43d2e..3795b75a43978381445b7edb65b07a544590a330 100644 (file)
@@ -1044,7 +1044,7 @@ static int imx296_probe(struct i2c_client *client)
                return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset),
                                     "failed to get reset GPIO\n");
 
-       sensor->clk = devm_clk_get(sensor->dev, "inck");
+       sensor->clk = devm_v4l2_sensor_clk_get(sensor->dev, "inck");
        if (IS_ERR(sensor->clk))
                return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk),
                                     "failed to get clock\n");