lib: Simplify asn1_tag_remaining()

Introduce common error exit

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

diff --git a/lib/util/asn1.c b/lib/util/asn1.c
index b6a54a09509690678a52db233c1fe9b0f2b197bc..47dafc904b216f6e92377c1431b4ae534ba844d7 100644 (file)
--- a/lib/util/asn1.c
+++ b/lib/util/asn1.c
@@ -751,19 +751,19 @@ int asn1_tag_remaining(struct asn1_data *data)
        }
 
        if (!data->nesting) {
-               data->has_error = true;
-               return -1;
+               goto error;
        }
        remaining = data->nesting->taglen - (data->ofs - data->nesting->start);
        if (remaining > (data->length - data->ofs)) {
-               data->has_error = true;
-               return -1;
+               goto error;
        }
        if (remaining < 0) {
-               data->has_error = true;
-               return -1;
+               goto error;
        }
        return remaining;
+error:
+       data->has_error = true;
+       return -1;
 }
 
 /**