ovl: port ovl_fadvise() to cred guard

Use the scoped ovl cred guard.

Link: https://patch.msgid.link/20251117-work-ovl-cred-guard-v4-11-b31603935724@kernel.org
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index 830a3cc8bbfc5c62cb22a377a321dc475345ecf4..73c805851e585ab8c8e05594a01a8aeb88743f41 100644 (file)
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -508,18 +508,13 @@ out_unlock:
 static int ovl_fadvise(struct file *file, loff_t offset, loff_t len, int advice)
 {
        struct file *realfile;
-       const struct cred *old_cred;
-       int ret;
 
        realfile = ovl_real_file(file);
        if (IS_ERR(realfile))
                return PTR_ERR(realfile);
 
-       old_cred = ovl_override_creds(file_inode(file)->i_sb);
-       ret = vfs_fadvise(realfile, offset, len, advice);
-       ovl_revert_creds(old_cred);
-
-       return ret;
+       with_ovl_creds(file_inode(file)->i_sb)
+               return vfs_fadvise(realfile, offset, len, advice);
 }
 
 enum ovl_copyop {