]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Demote 'INTRODUCE2 cell is too {old,new}' message to info level
authorRobert Ransom <rransom.8774@gmail.com>
Sun, 11 Sep 2011 01:40:09 +0000 (21:40 -0400)
committerRobert Ransom <rransom.8774@gmail.com>
Sun, 11 Sep 2011 01:56:05 +0000 (21:56 -0400)
changes/bug2442b [new file with mode: 0644]
src/or/rendservice.c

diff --git a/changes/bug2442b b/changes/bug2442b
new file mode 100644 (file)
index 0000000..02e1636
--- /dev/null
@@ -0,0 +1,8 @@
+  * Minor bugfixes:
+
+    - Demote the 'INTRODUCE2 cell is too {old,new}' log message to
+      info level.  There is nothing that a hidden service's operator
+      can do to fix its clients' clocks.  Bugfix on 0.2.1.6-alpha;
+      fixes part of bug 2442.
+
+
index 5f55537bc02baa222292c283429ec9b7df41a4b2..6ed9650fc161ec43bfd60b350d99f1a33d9fee6d 100644 (file)
@@ -1019,7 +1019,9 @@ rend_service_introduce(origin_circuit_t *circuit, const uint8_t *request,
     v3_shift += 4;
     if ((now - ts) < -1 * REND_REPLAY_TIME_INTERVAL / 2 ||
         (now - ts) > REND_REPLAY_TIME_INTERVAL / 2) {
-      log_warn(LD_REND, "INTRODUCE2 cell is too %s. Discarding.",
+      /* This is far more likely to mean that a client's clock is
+       * skewed than that a replay attack is in progress. */
+      log_info(LD_REND, "INTRODUCE2 cell is too %s. Discarding.",
                (now - ts) < 0 ? "old" : "new");
       return -1;
     }