]> git.ipfire.org Git - thirdparty/vuejs/core.git/commitdiff
refactor(reactivity): use NOOP for readonly computed setter in production
authorEvan You <yyx990803@gmail.com>
Wed, 9 Oct 2019 16:22:08 +0000 (12:22 -0400)
committerEvan You <yyx990803@gmail.com>
Wed, 9 Oct 2019 16:22:08 +0000 (12:22 -0400)
packages/reactivity/src/computed.ts

index b505e30157e14602d71101002417cec11cd38b79..9f2ede36758dd3f751e0426a975cd488a6dea716 100644 (file)
@@ -1,6 +1,6 @@
 import { effect, ReactiveEffect, activeReactiveEffectStack } from './effect'
 import { Ref, refSymbol, UnwrapNestedRefs } from './ref'
-import { isFunction } from '@vue/shared'
+import { isFunction, NOOP } from '@vue/shared'
 
 export interface ComputedRef<T> extends Ref<T> {
   readonly value: UnwrapNestedRefs<T>
@@ -28,11 +28,11 @@ export function computed<T>(
     ? (getterOrOptions as (() => T))
     : (getterOrOptions as WritableComputedOptions<T>).get
   const setter = isReadonly
-    ? () => {
-        if (__DEV__) {
+    ? __DEV__
+      ? () => {
           console.warn('Write operation failed: computed value is readonly')
         }
-      }
+      : NOOP
     : (getterOrOptions as WritableComputedOptions<T>).set
 
   let dirty = true