smb: client: fix potential UAF in cifs_debug_files_proc_show()

commit ca545b7f0823f19db0f1148d59bc5e1a56634502 upstream.

Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.

Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
[ This patch removes lock/unlock operation in routine cifs_ses_exiting()
  for ses_lock is not present in v5.10 and not ported yet. ses->status
  is protected by a global lock, cifs_tcp_ses_lock, in v5.10. ]
Signed-off-by: Jianqi Ren <jianqi.ren.cn@windriver.com>
Signed-off-by: He Zhe <zhe.he@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
index 53588d7517b4d0842e2d65575f25c94625524693..8b88b07054814629b65e79acabda2589ae849aad 100644 (file)
--- a/fs/cifs/cifs_debug.c
+++ b/fs/cifs/cifs_debug.c
@@ -183,6 +183,8 @@ static int cifs_debug_files_proc_show(struct seq_file *m, void *v)
                                    tcp_ses_list);
                list_for_each(tmp, &server->smb_ses_list) {
                        ses = list_entry(tmp, struct cifs_ses, smb_ses_list);
+                       if (cifs_ses_exiting(ses))
+                               continue;
                        list_for_each(tmp1, &ses->tcon_list) {
                                tcon = list_entry(tmp1, struct cifs_tcon, tcon_list);
                                spin_lock(&tcon->open_file_lock);

diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 92a7628560ccb00dcdcbada3e18f902289e35d05..b4aa7cd3a914b1b074ece7b466eac65677b82212 100644 (file)
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -2115,4 +2115,12 @@ static inline struct scatterlist *cifs_sg_set_buf(struct scatterlist *sg,
        return sg;
 }
 
+static inline bool cifs_ses_exiting(struct cifs_ses *ses)
+{
+       bool ret;
+
+       ret = ses->status == CifsExiting;
+       return ret;
+}
+
 #endif /* _CIFS_GLOB_H */