]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
thermal: intel: int340x: Use symbolic constant for UUID comparison
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Thu, 30 Oct 2025 03:59:55 +0000 (09:29 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 12 Nov 2025 20:13:13 +0000 (21:13 +0100)
Replace sizeof() with a symbolic constant for UUID matching to maintain
existing ABI behavior while improving code clarity. The current behavior
of comparing only the first 7 characters is sufficient to distinguish
all UUIDs and changing to full string comparison would alter the kernel
ABI, potentially breaking existing userspace applications.

Use a defined constant to make the truncated comparison explicit and
maintainable.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
[ rjw: Subject adjustments ]
Link: https://patch.msgid.link/20251030035955.62171-1-kaushlendra.kumar@intel.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/int340x_thermal/int3400_thermal.c

index 908cc1bf57f19f8030bb8a637a1a02ff144bf4ab..128556632685c45cad5b970450e04b448eb1dd92 100644 (file)
@@ -16,6 +16,8 @@
 #define INT3400_ODVP_CHANGED 0x88
 #define INT3400_KEEP_ALIVE 0xA0
 #define INT3400_FAKE_TEMP (20 * 1000) /* faked temp sensor with 20C */
+/* UUID prefix length for comparison - sufficient for all UUIDs */
+#define INT3400_UUID_PREFIX_LEN 7
 
 enum int3400_thermal_uuid {
        INT3400_THERMAL_ACTIVE = 0,
@@ -199,7 +201,7 @@ static ssize_t current_uuid_store(struct device *dev,
 
        for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; ++i) {
                if (!strncmp(buf, int3400_thermal_uuids[i],
-                            sizeof(int3400_thermal_uuids[i]) - 1)) {
+                            INT3400_UUID_PREFIX_LEN)) {
                        /*
                         * If we have a list of supported UUIDs, make sure
                         * this one is supported.