s4:kdc: Call krb5_free_principal() directly after to-be-freed principal is used

This simplifies the ‘out’ path.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index 4230ca3543c8a6a545f9765280b4f0e23c71847c..d2bc167d4bb03ecac54323ec823a90b91503dac9 100644 (file)
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -3020,12 +3020,9 @@ static krb5_error_code samba_kdc_seq(krb5_context context,
                                      SDB_F_ADMIN_DATA|SDB_F_GET_ANY,
                                      0 /* kvno */,
                                      priv->realm_dn, msg, entry);
+       krb5_free_principal(context, principal);
 
 out:
-       if (principal != NULL) {
-               krb5_free_principal(context, principal);
-       }
-
        if (ret != 0) {
                TALLOC_FREE(priv);
                kdc_db_ctx->seq_ctx = NULL;