]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Nov 2024 07:01:01 +0000 (08:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Nov 2024 07:01:01 +0000 (08:01 +0100)
added patches:
nilfs2-fix-kernel-bug-due-to-missing-clearing-of-checked-flag.patch

queue-5.4/nilfs2-fix-kernel-bug-due-to-missing-clearing-of-checked-flag.patch [new file with mode: 0644]
queue-5.4/series

diff --git a/queue-5.4/nilfs2-fix-kernel-bug-due-to-missing-clearing-of-checked-flag.patch b/queue-5.4/nilfs2-fix-kernel-bug-due-to-missing-clearing-of-checked-flag.patch
new file mode 100644 (file)
index 0000000..134d43b
--- /dev/null
@@ -0,0 +1,45 @@
+From 41e192ad2779cae0102879612dfe46726e4396aa Mon Sep 17 00:00:00 2001
+From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
+Date: Fri, 18 Oct 2024 04:33:10 +0900
+Subject: nilfs2: fix kernel bug due to missing clearing of checked flag
+
+From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
+
+commit 41e192ad2779cae0102879612dfe46726e4396aa upstream.
+
+Syzbot reported that in directory operations after nilfs2 detects
+filesystem corruption and degrades to read-only,
+__block_write_begin_int(), which is called to prepare block writes, may
+fail the BUG_ON check for accesses exceeding the folio/page size,
+triggering a kernel bug.
+
+This was found to be because the "checked" flag of a page/folio was not
+cleared when it was discarded by nilfs2's own routine, which causes the
+sanity check of directory entries to be skipped when the directory
+page/folio is reloaded.  So, fix that.
+
+This was necessary when the use of nilfs2's own page discard routine was
+applied to more than just metadata files.
+
+Link: https://lkml.kernel.org/r/20241017193359.5051-1-konishi.ryusuke@gmail.com
+Fixes: 8c26c4e2694a ("nilfs2: fix issue with flush kernel thread after remount in RO mode because of driver's internal error or metadata corruption")
+Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
+Reported-by: syzbot+d6ca2daf692c7a82f959@syzkaller.appspotmail.com
+Closes: https://syzkaller.appspot.com/bug?extid=d6ca2daf692c7a82f959
+Cc: <stable@vger.kernel.org>
+Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/nilfs2/page.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/fs/nilfs2/page.c
++++ b/fs/nilfs2/page.c
+@@ -405,6 +405,7 @@ void nilfs_clear_dirty_page(struct page
+       ClearPageUptodate(page);
+       ClearPageMappedToDisk(page);
++      ClearPageChecked(page);
+       if (page_has_buffers(page)) {
+               struct buffer_head *bh, *head;
index 3531ea4abc6c4c7150d08e08342c47f2350e2789..d6a143677414be09a1d186dccf7abce905812d1c 100644 (file)
@@ -454,3 +454,4 @@ staging-iio-frequency-ad9832-fix-division-by-zero-in-ad9832_calc_freqreg.patch
 nilfs2-fix-potential-deadlock-with-newly-created-symlinks.patch
 riscv-remove-unused-generating_asm_offsets.patch
 ocfs2-pass-u64-to-ocfs2_truncate_inline-maybe-overfl.patch
+nilfs2-fix-kernel-bug-due-to-missing-clearing-of-checked-flag.patch