]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-127146: xfail more Emscripten stack overflows (#134358)
authorHood Chatham <roberthoodchatham@gmail.com>
Tue, 20 May 2025 18:41:14 +0000 (14:41 -0400)
committerGitHub <noreply@github.com>
Tue, 20 May 2025 18:41:14 +0000 (18:41 +0000)
Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.

Lib/test/test_builtin.py
Lib/test/test_capi/test_misc.py
Lib/test/test_descr.py
Lib/test/test_exceptions.py
Lib/test/test_io.py

index 31597a320d418adc2e2c3a688966ef7fe432b237..f1f877c47a1e7ab627704a2d71aa6b930a9af615 100644 (file)
@@ -1120,6 +1120,7 @@ class BuiltinTest(ComplexesAreIdenticalMixin, unittest.TestCase):
             self.check_iter_pickle(f1, list(f2), proto)
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_filter_dealloc(self):
         # Tests recursive deallocation of nested filter objects using the
index a597f23a992e7b2f68a9a3bc57e262f7f7f134b8..f74694a7a745a46e404fe170364f3edc88338c74 100644 (file)
@@ -412,10 +412,12 @@ class CAPITest(unittest.TestCase):
             L = MyList((L,))
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class1(self):
         self.do_test_trashcan_python_class(list)
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class2(self):
         from _testcapi import MyList
         self.do_test_trashcan_python_class(MyList)
index 76937432a43037e64186105594dec078d55410a1..14026531e2233306a2402f07066c6e15d4c3d395 100644 (file)
@@ -4523,6 +4523,7 @@ class ClassPropertiesAndMethods(unittest.TestCase):
         del o
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_wrapper_segfault(self):
         # SF 927248: deeply nested wrappers could cause stack overflow
index d177e3dc0f5007ab75e8724f9ccebe08b8103b6b..cfd4a3e87695f538c4e22b227644ebffa6497878 100644 (file)
@@ -1429,6 +1429,7 @@ class ExceptionTests(unittest.TestCase):
         self.assertIn("maximum recursion depth exceeded", str(exc))
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @cpython_only
     @support.requires_resource('cpu')
     def test_trashcan_recursion(self):
index 5a8f1949baaa9831012ad86ae82075f0b64d1797..90680c6d47ab4183518347b7f9692acacd98c5f8 100644 (file)
@@ -572,7 +572,7 @@ class IOTest(unittest.TestCase):
         for [test, abilities] in tests:
             with self.subTest(test):
                 if test == pipe_writer and not threading_helper.can_start_thread:
-                    skipTest()
+                    self.skipTest("Need threads")
                 with test() as obj:
                     do_test(test, obj, abilities)